feat: destructuring of structs and messages #856

Gusarich · 2024-09-20T09:04:08Z

Issue

Closes #298.

Checklist

I have updated CHANGELOG.md
I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
I have run all the tests locally and no test failure was reported
I have run the linter, formatter and spellchecker
I did not do unrelated and/or undiscussed refactorings

src/interpreter.ts

src/generator/writers/writeFunction.ts

anton-trunov

See my comment for the grammar.ohm file

src/grammar/grammar.ohm

Gusarich · 2024-10-08T10:18:26Z

@jeshecdom @anton-trunov have a look at the reworked apporach please!

anton-trunov · 2024-10-08T11:45:25Z

@Gusarich There are some merge conflicts

Gusarich · 2024-10-08T12:03:14Z

@Gusarich There are some merge conflicts

Resolved them, trying to push but knip doesn't let me because for some reason it thinks that @types/jest is not used. What should I do?

anton-trunov · 2024-10-08T18:38:46Z

Resolved them, trying to push but knip doesn't let me because for some reason it thinks that @types/jest is not used. What should I do?

hmmm, this is weird, because I removed that from ignoreDependencies (see the getter method id pr) precisely because I was getting warnings that it is useless

can you try updating your knip installation locally?

Gusarich · 2024-10-08T23:52:45Z

can you try updating your knip installation locally?

yeah, just had to run yarn. didn't notice the change in package.json. have a look now

anton-trunov

I left a few comments and suggestions for the changes. Since this is a complex feature (yeah, codegen is quite simple, but the static semantics is a bit tricky), we need to test it more thoroughly, so let's add at least the following tests:

positive interpreter (const-eval) tests (including various combinations of punned and mapped fields);
negative interpreter tests;
negative typechecker tests with the scoping rules violations, like let S {x: x, y: x} and shadowing of previously defined variables;
negative typechecker tests with all the new error messages (that are non-ICE ones);
pretty-printer tests;
renamer tests;

src/grammar/grammar.ohm

src/grammar/ast.ts

src/grammar/grammar.ohm

src/grammar/ast.ts

src/grammar/test/stmt-destructuring.tact

src/test/e2e-emulated/contracts/structs.tact

anton-trunov · 2024-10-09T06:37:34Z

@jeshecdom Please have a look at the interpreter changes and suggest more positive and negative tests. And also, please help with the var-scoping and typechecking rules review

anton-trunov · 2024-10-09T07:15:05Z

Also, let's document this feature: look at how it's done in PR feat: specify method ID for getters #922 ("available since").
And let's add some more negative tests for the typechecker in this style: let S1 {x, y} = S2 {x: 42, y: 43}

src/interpreter.ts

novusnota · 2024-10-10T04:10:47Z

Also, let's document this feature: look at how it's done in PR #922 ("available since").

If needed, I can quickly help write the docs once all the other suggestions above are resolved :)

Gusarich · 2024-10-11T01:15:44Z

@anton-trunov @jeshecdom I think I've made all the changes you requested in the review. Please have a look!

Discovered and fixed a few small bugs while writing all these tests 👍

jeshecdom

LGTM, @anton-trunov

src/generator/writers/writeFunction.ts

src/test/e2e-emulated/contracts/structs.tact

src/types/__snapshots__/resolveStatements.spec.ts.snap

src/grammar/grammar.ts

src/grammar/ast.ts

Gusarich · 2024-10-14T11:02:34Z

@anton-trunov resolved everything, have a look please!

src/grammar/ast.ts

Co-authored-by: Novus Nota <[email protected]>

anton-trunov · 2024-10-15T15:16:00Z

If needed, I can quickly help write the docs once all the other suggestions above are resolved :)

@novusnota your turn :)

novusnota · 2024-10-15T16:23:29Z

@anton-trunov on it!

UPD: #964

Gusarich added this to the v1.6.0 milestone Sep 20, 2024

Gusarich requested a review from a team as a code owner September 20, 2024 09:04

jeshecdom reviewed Sep 20, 2024

View reviewed changes

src/interpreter.ts Outdated Show resolved Hide resolved

anton-trunov self-assigned this Sep 23, 2024

anton-trunov reviewed Sep 23, 2024

View reviewed changes

src/generator/writers/writeFunction.ts Outdated Show resolved Hide resolved

anton-trunov requested changes Sep 23, 2024

View reviewed changes

src/grammar/grammar.ohm Outdated Show resolved Hide resolved

Gusarich requested review from anton-trunov and jeshecdom October 8, 2024 10:23

Gusarich force-pushed the destruct branch from ef1e6e2 to 6c3ba88 Compare October 8, 2024 23:52

anton-trunov requested changes Oct 9, 2024

View reviewed changes

jeshecdom reviewed Oct 9, 2024

View reviewed changes

src/interpreter.ts Show resolved Hide resolved

Gusarich force-pushed the destruct branch from cc4ac30 to be92387 Compare October 11, 2024 01:12

Gusarich requested review from jeshecdom and anton-trunov October 11, 2024 01:15

jeshecdom reviewed Oct 11, 2024

View reviewed changes

anton-trunov requested changes Oct 13, 2024

View reviewed changes

Gusarich added 5 commits October 14, 2024 14:00

feat: grammar

0af4816

feat: implement destructuring and add e2e test

74e7d26

chore: add more test cases

618611d

feat: interpreter and iterator

ce74a73

chore: add test with message

62ab487

Gusarich added 20 commits October 14, 2024 14:00

feat: fixes after updating grammar

70f0ad0

feat: make destruct identifiers to a map instead of an array

8c355cb

chore: add more typechecker test cases

32f80b4

chore: add one more typechecker test and rename them

2151c54

chore: add one more typechecker test

c3ee0af

fix: compare specified type and expression type

9bae96e

chore: one more typechecker test

f6d07c5

chore: pretty printer test

72a03e0

feat: implement renamer and add test case

10a8219

chore: more e2e test cases

7091ed5

fix: handle wildcard names in interpreter

f66979b

chore: add interpreter test cases

7cb3a91

fix: compare identifiers map correctly in ast comparison

107c110

chore: use .toMatchObject for convenience

c2499fd

fix: correctly handle _ names

43567ac

fix: do not skip resolving for wildcard identifiers

4d01919

fix: adjust test code after fix

aca6e69

chore: change the error test

d5b3d75

feat: rework identifiers map and handle duplicate source ids

bd223f4

fix: adjust comparing and hashing and a few tests

72ea7b1

Gusarich force-pushed the destruct branch from f1b2c45 to 72ea7b1 Compare October 14, 2024 11:01

Gusarich requested a review from anton-trunov October 14, 2024 11:02

novusnota reviewed Oct 14, 2024

View reviewed changes

src/grammar/ast.ts Outdated Show resolved Hide resolved

Update src/grammar/ast.ts

0cbf128

Co-authored-by: Novus Nota <[email protected]>

anton-trunov approved these changes Oct 15, 2024

View reviewed changes

anton-trunov merged commit ce201fb into tact-lang:main Oct 15, 2024
15 checks passed

novusnota mentioned this pull request Oct 16, 2024

feat(docs): destructuring statement #964

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: destructuring of structs and messages #856

feat: destructuring of structs and messages #856

Gusarich commented Sep 20, 2024

anton-trunov left a comment

Gusarich commented Oct 8, 2024

anton-trunov commented Oct 8, 2024

Gusarich commented Oct 8, 2024

anton-trunov commented Oct 8, 2024

Gusarich commented Oct 8, 2024

anton-trunov left a comment

anton-trunov commented Oct 9, 2024 •

edited

Loading

anton-trunov commented Oct 9, 2024

novusnota commented Oct 10, 2024 •

edited

Loading

Gusarich commented Oct 11, 2024 •

edited

Loading

jeshecdom left a comment

Gusarich commented Oct 14, 2024 •

edited

Loading

anton-trunov commented Oct 15, 2024 •

edited

Loading

novusnota commented Oct 15, 2024 •

edited

Loading

feat: destructuring of structs and messages #856

feat: destructuring of structs and messages #856

Conversation

Gusarich commented Sep 20, 2024

Issue

Checklist

anton-trunov left a comment

Choose a reason for hiding this comment

Gusarich commented Oct 8, 2024

anton-trunov commented Oct 8, 2024

Gusarich commented Oct 8, 2024

anton-trunov commented Oct 8, 2024

Gusarich commented Oct 8, 2024

anton-trunov left a comment

Choose a reason for hiding this comment

anton-trunov commented Oct 9, 2024 • edited Loading

anton-trunov commented Oct 9, 2024

novusnota commented Oct 10, 2024 • edited Loading

Gusarich commented Oct 11, 2024 • edited Loading

jeshecdom left a comment

Choose a reason for hiding this comment

Gusarich commented Oct 14, 2024 • edited Loading

anton-trunov commented Oct 15, 2024 • edited Loading

novusnota commented Oct 15, 2024 • edited Loading

anton-trunov commented Oct 9, 2024 •

edited

Loading

novusnota commented Oct 10, 2024 •

edited

Loading

Gusarich commented Oct 11, 2024 •

edited

Loading

Gusarich commented Oct 14, 2024 •

edited

Loading

anton-trunov commented Oct 15, 2024 •

edited

Loading

novusnota commented Oct 15, 2024 •

edited

Loading